squeaky-pl / japronto

Screaming-fast Python 3.5+ HTTP toolkit integrated with pipelining HTTP server based on uvloop and picohttpparser.
MIT License
8.61k stars 581 forks source link

stop logging every http request #152

Closed andersmartini closed 5 years ago

andersmartini commented 5 years ago

Greetings!

first of all, thanks for writing such a fast webframework! good job!

I found that logging every single request was a bit too much logging for our purposes, so I made this PR to remove it. outside of debugging and testing japronto itself, I really don't think this is desirable very often. usually applications will have logging infrastructure around them that require logging in certain formats as well (for example, we require json logging). I'm very much open for discussion on this.

I read on reddit somewhere that you were going to create a CONTRIBUTING file, but I couldn't find it so I assumed you hadn't gotten around to it yet! Do tell me if there's anything more you need me to do to get this merged :)