squeaky-pl / japronto

Screaming-fast Python 3.5+ HTTP toolkit integrated with pipelining HTTP server based on uvloop and picohttpparser.
MIT License
8.61k stars 581 forks source link

Small installation issue on mac #18

Closed ryandietrich closed 7 years ago

ryandietrich commented 7 years ago

The strip command on Mac requires -x or it gets angry.

index 4d3468b..efc8c8e 100755
--- a/src/picohttpparser/build
+++ b/src/picohttpparser/build
@@ -4,4 +4,10 @@ set -ex

 gcc -c picohttpparser.c -O3 -fpic -msse4.2
 gcc -shared -o libpicohttpparser.so picohttpparser.o
-strip libpicohttpparser.so
+if [[ `uname` == "Darwin" ]]
+then
+    strip -x libpicohttpparser.so
+else
+    strip libpicohttpparser.so
+fi
+    
luizberti commented 7 years ago

1

squeaky-pl commented 7 years ago

Can you make a pull request, I'm away from my laptop unfortunately and wont graft this easily on my phone? Thanks

squeaky-pl commented 7 years ago

Thanks.