search

squeaky-pl / portable-pypy

Portable 64 bit x86 PyPy binaries for many Linux distributions.
Other
478 stars 38 forks source link

READY FOR REVIEW - Add `mkall` script and modify build process to accommodate building via a VM (e.g., Vagrant plus boot2docker). #14

Closed posita closed 2 years ago

posita commented 9 years ago

This is an extension of the work done for addressing #10. The updated BUILD.rst file should give more details, but basically, this PR does two things:

  1. It includes a mkall wrapper script around the various docker build/run phases so one can do a build in one step.
  2. It abstracts certain configuration variables to allow Portable PyPy to be built using a native file system, but where docker is run in a VM (e.g., boot2docker and Vagrant). This is a common setup for those who do not run Linux natively.

This is just a proposal, so feel free to reject it entirely without hurting my feelings. :grin: I would be interested in getting your feedback though.

One thing to note is that the handling of REVISION is changed. It's now submitted as an environment variable to runopt.sh for consistency with ABI. The proposed mkall wrapper provides a more user-friendly abstraction, however.

squeaky-pl commented 9 years ago

I am gonna merge it step by step since I have some objections. My first objection is copying the scripts into the image, it kind of breaks my workflow. I know that this is not the docker way since docker is used mainly for deploying. In this case I use docker for development, building an image can be slow, even if it only invalidates the last step, by using volume mounts i can do things faster.

posita commented 9 years ago

No worries. I'm sympathetic to the Docker-for-development thing (which the Docker folks seem to have greatly ignored so far), so I understand how what I proposed may not be ideal. I'm glad it provides some inspiration, at least! :blush:

Feel free to close this when you've mined all you want from it.