search

squeaky-pl / portable-pypy

Portable 64 bit x86 PyPy binaries for many Linux distributions.
Other
478 stars 38 forks source link

Bug - Platform version in socket.append.py #54

Closed audiolion closed 7 years ago

audiolion commented 7 years ago

On my server RHEL 7 the kernel version is "4.1.39_1"

The code: https://github.com/squeaky-pl/portable-pypy/blob/master/socket.append.py#L13

splits on -, as a result it tries to map(int, '39_1') and fails because it can't convert that to an int, I had to edit the source code to split on _ to use the portable pypy install.

squeaky-pl commented 7 years ago

Oh. I knew I am gonna regret this, this is needed though because not all of those symbols will be available on the platform where it is translated. Gonna fix ASAP.

squeaky-pl commented 7 years ago

I issued a bugfix release. I dont have a machine with RHEL. Can you try to import socket on:

https://bitbucket.org/squeaky/portable-pypy/downloads/pypy3.5-5.8-1-beta-linux_x86_64-portable.tar.bz2

and

https://bitbucket.org/squeaky/portable-pypy/downloads/pypy-5.8-1-linux_x86_64-portable.tar.bz2

audiolion commented 7 years ago

Yeah its working, now it outputs (4, 1, 39, 1) and doesn't crash 👍

squeaky-pl commented 7 years ago

Thanks for the report and testing.