search

squeeglii / BridgingMod

A mod for Minecraft (1.17-1.20+) which adds bedrock-style reacharound-placement mechanics for Fabric, Quilt & Forge
MIT License
8 stars 7 forks source link

[Suggestion] Block placement preview #8

Closed nco2k closed 5 months ago

nco2k commented 5 months ago

i really like the "Bridge-assist block outline" feature, and would like to suggest an option to always show a block placement preview, not just when bridging. this way we could use your mod as a general purpose block placement preview mod. it should of course respect the "Only use bridge-assist while crouching" setting.

squeeglii commented 5 months ago

I'm a little bit confused by this as vanilla shows an outline when bridging is not being used. Are you suggesting shifting that vanilla outline from the block you can break to the air gap where you can place?

nco2k commented 5 months ago

yes.

currently your mod allows us to show an outline when you can bridge: pic1

im suggesting an option to show that outline whenever you can place a block: pic2

it shouldnt ofc remove the vanilla breaking block outline, but show yours as an addition. this could be incredibly useful at times. especially if you were up for adding another option to show a shape preview like for example when using stairs. this way we can make sure to never accidentally connect them the wrong way. but i think that might go beyond the scope of your mod. one can dream though. :D

squeeglii commented 5 months ago

Ahh awesome. Adding that shouldn't be too bad then. Will consider fancy outlines for a later update but a simple box will do for now.

Should be in the next update! :]

squeeglii commented 5 months ago

Implemented with a few config options - it's off by default but the you can find the setting in the "Visual" category.

Will be in v2.3.0. Thanks for the suggestion!

nco2k commented 5 months ago

wow that was fast. thanks for adding this!

there is one small cosmetic issue though. the bridging outline color (white) merges with the vanilla outline color (black) and therefor creates a new in-between color (grey) when the two outlines overlap. any chance you can fix that?

outline1 outline2

squeeglii commented 5 months ago

Have you set the lines to full opacity? The colour #ffffffff should do that. Transparency will lead to blending and there's not an easy way to fix that without modifying the vanilla outline.

nco2k commented 5 months ago

yes im using #ffffffff

squeeglii commented 5 months ago

Strange - it didn't look the same on my end. Are you using any mods that modify your graphics? I've tried it on Fast, Fancy, & Fabulous on Fabric.

nco2k commented 5 months ago

okay it looks like its caused by Iris Shaders, even if no shader pack is currently being used.

i could reproduce it with just the following mods:

as soon as i remove Iris Shaders, it works as intended. very strange.

squeeglii commented 5 months ago

fuuuun, I love vague and mysterious graphical bugs. 💀

Will move this into a new issue. Not sure how long it'll take to fix as it's quite minor and doesn't have a clear cause, but I'll take a look either way.