search

squeek502 / AppleCore

An API for modifying the food and hunger mechanics of Minecraft
The Unlicense
55 stars 24 forks source link

Conflict with Bed Patch #114

Open Mordenkainen opened 6 years ago

Mordenkainen commented 6 years ago

It appears AppleCore conflicts with BedPatch as detailed in Mordenkainen/BedPatch#2.

This seems to be the same failure as in issue #89.

Looking at the ASM patching done by both BedPatch and AppleCore I do not see any direct conflict as we are editing different classes. But it almost seems that if BedPatch patches the Chunk class, AppleCore fails to patch the EntityPlayer class. I am not sure of the exact cause of the issue.

I have found that if I change the SortingIndex of BedPatch to be after AppleCore, the issue goes away and both mods are able to make the patches they need.

I am updating Bed Patch with this change, but wanted to open an issue here so you would be aware, as this may help track down the compatibility issue in #89.

If you understand why these mods are clashing, please let me know as I would like to understand what the source of the conflict was.

squeek502 commented 6 years ago

Very strange, thanks for letting me know about it. Will try to look into it soon.