search

squeek502 / AppleCore

An API for modifying the food and hunger mechanics of Minecraft
The Unlicense
55 stars 24 forks source link

AppleCore doesn't trigger an error when used with the wrong MC version #84

Closed Syndaryl closed 7 years ago

Syndaryl commented 7 years ago

Which is causing errors and threatening messages in the Forge log...

GirafiStudios commented 7 years ago

Well first of all Apple Core is not released for 1.11.2 just yet. And yes Apple Cores ID for 1.11.2 is lowercased https://github.com/squeek502/AppleCore/blob/1.11.2/java/squeek/applecore/ModInfo.java#L5.

Syndaryl commented 7 years ago

OK, I'm a little confused since I got it off Curseforge yesterday (along with Appleskin). Looking at the JAR again it's the 1.10.2 not 1.11.2 - but I have no idea why forge wouldn't just reject it for being the wrong version entirely. shrug Oh well, sorry for bothering you.

squeek502 commented 7 years ago

Yeah, it might be a good idea for us to use acceptedMinecraftVersions to make Forge trigger an error on incompatible MC versions. Even weirder is that the core mod part of AppleCore is locked to the MC version and definitely wouldn't have loaded if you tried to use the 1.10.2 version with 1.11.2.

Re-opening for now, will close again when acceptedMinecraftVersions gets set.

Syndaryl commented 7 years ago

Sounds good for me.

squeek502 commented 7 years ago

Also worth mentioning just in case you weren't aware that AppleSkin doesn't depend on AppleCore, it's completely standalone.

Syndaryl commented 7 years ago

I didn't realize that yesterday, but I put two and two together finally today :)

squeek502 commented 7 years ago

@Syndaryl released an actual 1.11.2 version as well: https://minecraft.curseforge.com/projects/applecore/files/2378384

Syndaryl commented 7 years ago

Most excellent!