squeek502 / AppleSkin

Food-related HUD improvements for Minecraft (AppleCore without the core)
https://minecraft.curseforge.com/projects/appleskin
The Unlicense
342 stars 60 forks source link

Incompatibility with Origins / MoreBeeInfo #222

Open Shines113 opened 1 year ago

Shines113 commented 1 year ago

The specific context of this is that I tried to install All Of Fabric 6 (Version 1.3.0, which contains appleskin-fabric-mc1.19-2.4.1.jar) and added the Origins (Fabric) (Origins-1.19.2-1.7.1.jar) and the mod crashed as soon as I would launch.

After going through and manually disabling several mods, I found that the culprit seemed to be Appleskin, after disabling it (and re-enabling three mods that had it listed as a dependency: bewitchment, bewitchment plus, and besmirchment) the pack seems to work just fine, sans food information. I'm not sure what's causing this issue, or how it could be corrected.

squeek502 commented 1 year ago

The crash log would be helpful.

Shines113 commented 1 year ago

It absolutely would, I don't know why I completely spaced attaching one. Here is one from a fresh install of the modpack with the origins version added in. latest.log

SAGESSE-CN commented 1 year ago

try remove bee_info 1.0.1

Shines113 commented 1 year ago

That seems to work- So the compatibility issue is having appleskin, bee info, and origins together somehow, and disabling any one of the three makes it function?

squeek502 commented 1 year ago

For reference, here are the links to the relevant mods:

SAGESSE-CN commented 1 year ago

for the bee info, because we use same mixin

https://github.com/squeek502/AppleSkin/blob/7f62c3743df801fc6e8faa1d5977c90a844503f4/java/squeek/appleskin/mixin/ItemStackMixin.java#L18

https://github.com/anviaan/MoreBeeInfo/blob/78b3aba51377885aa0a2730e2f5dcdf2efdbfe2e/src/main/java/net/anvian/bee_info/mixin/TooltipMixin.java#L29

SAGESSE-CN commented 1 year ago

I think it's their problem, because their use capature.