search

squeek502 / AppleSkin

Food-related HUD improvements for Minecraft (AppleCore without the core)
https://minecraft.curseforge.com/projects/appleskin
The Unlicense
349 stars 62 forks source link

Modrinth doesn't allow client side: `required` with server side: `optional` #288

Open dhouck opened 9 months ago

dhouck commented 9 months ago

Currently, Modrinth reports that this mod is unsupported on servers. Unless there have been some big changes since I last checked, this is incorrect; the Modrinth metadata should be updated to say itʼs optional for servers and required for clients.

(Alternately, if the metadata is correct, the description is out of date as it recommends installing on the server too)

Edit: add screenshot image

squeek502 commented 9 months ago

Thanks, fixed. Not sure what happened as it was set to optional before, see https://github.com/squeek502/AppleSkin/issues/275

dhouck commented 9 months ago

Iʼm still seeing it as unsupported; is that sometimes slow to propagate, or will it only take effect with a new version?

squeek502 commented 9 months ago

Seems like a Modrinth bug, it keeps resetting to "Unsupported" somehow.

squeek502 commented 6 months ago

Set both client and server side to required for now since Modrinth seems to only allow certain combinations and 'client required + server optional' doesn't seem to be an allowed combination.

The relevant issue is https://github.com/modrinth/code/issues/2586

EDIT: Actually, re-set it as 'unsupported' on the server-side to avoid the scenario in https://github.com/squeek502/AppleSkin/issues/275

EDIT#2: On third thought, I think setting client-side and server-side to 'optional' might make the most sense, so I did that.

Will need a fix on Modrinth's end to get this set properly.