search

squeek502 / WailaHarvestability

Minecraft mod that adds required harvest level and the effective tool to Waila tooltips of harvestable blocks
The Unlicense
17 stars 21 forks source link

gregtech effective tool wrong #52

Open Nex4rius opened 7 years ago

Nex4rius commented 7 years ago

The effective tool for gregtech cables is wrong.

It should be a wirecutter instead of a wrench.

The effective tool for gregtech wooden fluid pipes is wrong too.

The tool for all pipes is a wrench except when its made out of wood then you need an axe.

gregtech-5.09.26 Waila-1.5.10_1.7.10 WailaHarvestability-mc1.7.10-1.1.6

squeek502 commented 7 years ago

That string comes from a standard Minecraft/Forge method (block.getHarvestTool(metadata) in this instance), so the possibilities are:

  1. Gregtech is returning the wrong string for those blocks
  2. Wrench is also an effective tool for those blocks, and the limitations of the Minecraft effective tool system don't allow me to retrieve all the different possible effective tools.
Nex4rius commented 7 years ago
  1. I think we have to ask @Blood-Asp about that.
  2. No the wrench does not work at all on these blocks.
richardhendricks commented 6 years ago

Saber - Today at 2:42 AM IC2 Fluid/Solid Canning Machine Effective Tool: Pickaxe

Me: "huh, not wrench, guess IC2 is weird like that" -mines it- -acquires 1 basic machine casing- :unamused:

squeek502 commented 4 years ago

Note: this could be fixed by pulling in https://github.com/squeek502/WailaHarvestability/commit/741a44a4c8640094c966134306ddbe0ef1015588 from https://github.com/GTNewHorizons/WailaHarvestability/pull/1.