squeek502 / WailaHarvestability

Minecraft mod that adds required harvest level and the effective tool to Waila tooltips of harvestable blocks
The Unlicense
17 stars 21 forks source link

1.12 double-height flowers say you need shears #57

Open Zygus42 opened 7 years ago

Zygus42 commented 7 years ago

WailaHarvestability-mc1.12-1.1.11 Hwyla-1.8.19-B33_1.12

Double-height flowers (sun flower, rosebush, etc) say you need shears but you can collect them by hand - single-height flowers are fine.

squeek502 commented 7 years ago

I'm not really sure what to do about this. The info shown currently is technically correct: all double plant blocks are marked as 'shearable', but its isShearable check only returns true for the bottoms of ferns and double grass. The unfortunate part is that it's not really possible to determine when something is never shearable, and when something is just temporarily unshearable (e.g. something that works like sheep's wool which returns false from isShearable when the wool is growing back).

So, the fix I guess would be to add a special case for things I know aren't ever shearable, but I don't really like that solution...