search

squeevee / flarum-ext-fancybox

Image formatting and lightbox modal using FancyBox
GNU General Public License v3.0
6 stars 5 forks source link

Using an external image will not work properly and will become a small image, such as https://www.google.com/img.jpg #2

Closed LeannaClaire closed 5 years ago

LeannaClaire commented 5 years ago

Using an external image will not work properly and will become a small image, such as https://www.google.com/img.jpg

LeannaClaire commented 5 years ago

Use the external chain picture, it can not be used normally, it will become a small picture, only the locally uploaded picture can use the enlarged picture normally. When using the external chain picture, the editor will automatically add hyperlink, there is a super chain picture Can't use zoom function normally, attachment view demo, such as https://www.google.com/img.jpg 微信截图_20190426174618

微信图片_20190426174504

LeannaClaire commented 5 years ago

I hope that the images in the outer chain will also start the FancyBox mode, otherwise the experience is too bad, because my pictures are all third-party libraries.

squeevee commented 5 years ago

@iosmall

The way I have designed it, an image wrapped in an external link does this behavior so that the the link will still be available. It looks like the link has the same URL as the image, so it would make sense for this to be an exception to that part of the design.

I'll make this change a part of the next beta release, hopefully within the next week.

I'd like to know more about your situation though, if that's okay.

my pictures are all third-party libraries

What third-party libraries are you using with regards to the images? Would you mind sharing the markup you used in the post?

LeannaClaire commented 5 years ago

Because my pictures are all saved in a third-party gallery. weibo.com https://github.com/Semibold/Weibo-Picture-Store

LeannaClaire commented 5 years ago

Anyway, as long as it is not a locally uploaded image, it will shrink.

LeannaClaire commented 5 years ago

The external chain image I use will automatically add a hyperlink. Very depressed 微信截图_20190512214203

LeannaClaire commented 5 years ago

There is a serious problem, the mobile browser can't display the picture.

squeevee commented 5 years ago

Because my pictures are all saved in a third-party gallery. weibo.com https://github.com/Semibold/Weibo-Picture-Store

I'm afraid I still don't understand fully. I am not aware of any Weibo extension for Flarum. There is a step in-between uploading the image to Weibo, and putting it on Flarum. Do you copy and paste the URL of the image? Or is there an extension for Flarum that I'm not aware of?

I have issued a new Beta release, so please update your extension, clear your Flarum cache, and see if the issues are still affecting you.

squeevee commented 5 years ago

I have not been able to reproduce this issue on version 0.2-beta. using extension fof/formatting I was able to paste the url to an image and it worked as expected. If you're still having issues, please make sure that you have version 0.2-beta installed by running

composer show squeevee/flarum-ext-fancybox

and checking the version number