search

squentin / gmusicbrowser

jukebox for large collections of music
http://gmusicbrowser.org
GNU General Public License v3.0
194 stars 42 forks source link

Invalid/mangled/malformed uri in MPRIS2 #138

Open JasonLG1979 opened 7 years ago

JasonLG1979 commented 7 years ago

This is an example of what I get from gmusicbroswer. file:///run/media/jason/Backups/Music/7%20Horns%207%20Eyes/7%20Horns%207%20Eyes/01%20Yet%20You%20Still%20Choke.mp3%3Aalbum

I don't know what that is? Are you trying to get MPRIS2 to read the image tag in the audio file? If so you can't do that, the uri has to point an actual standalone image file the MPRIS2 spec says nothing about extracting images from an audio file. If your intent is to create a temp file it fails more often than not in my experience. In either case your implementation is broken. You would do better to either have a separate cover cache or at least check the music folder for image files.

See https://github.com/eonpatapon/gnome-shell-extensions-mediaplayer/issues/237

JasonLG1979 commented 7 years ago

OK... Well I'm going to list gmusicbrowser as a broken player at https://github.com/eonpatapon/gnome-shell-extensions-mediaplayer as more often than not the file path given in the mpris metadata is mangled/invaild for the purposes of mpris.