squentin / gmusicbrowser

jukebox for large collections of music
http://gmusicbrowser.org
GNU General Public License v3.0
194 stars 42 forks source link

use mpg123 instead of mpg321? mpg321 appears not actively maintained #218

Closed MountainX closed 2 years ago

MountainX commented 2 years ago

Can GMB use mpg123 instead of mpg321?

I ask because I am not able to build the mpg321 package for Arch: AUR (en) - mpg321

Also, mpg123 has a new release on 2021-09-06 17:26 UTC, while mpg321 was last updated 2012-03-25.

The license is no longer an issue:

mpg123 - Wikipedia

In 2006, a new maintainer started work towards the release of a new official mpg123 package. After several security rollup releases in the 0.6.x series, version 1.0 was released in 2007 under the LGPLv2.1

MountainX commented 2 years ago

I added this issue because of this message during installation:

( 9/28) installing gmusicbrowser-git                                                             [#########################################################] 100%
Optional dependencies for gmusicbrowser-git
    alsa-utils: enables the ALSA backend [installed]
    flac123: flac support for the ALSA backend
    mpg321: mp3 support for the ALSA backend
    vorbis-tools: vorbis support for the ALSA backend
    mplayer: enables the mplayer backend
    mpv: enables the mpv backend [installed]
    gst-plugins-base: vorbis support [installed]
    gst-plugins-good: flac support [installed]
    gst-plugins-ugly: mp3 support
    libappindicator-gtk3: tray icon support [installed]
    webkit2gtk: alternative web-based plugin support [installed]
    libwnck3: titlebar plugin support
    perl-html-parser: support for accented characters in lyrics plugin [installed]
    libnotify: support for notify plugin [installed]

As you see, it says "mpg321" explicitly there. However, I realize now that the problem is the Arch Linux PKGBUILD file, not the application.

PKGBUILD - aur.git - AUR Package Repositories

This PKGBUILD has the wrong optdepends defined, apparently.

squentin commented 2 years ago

Yes both mpg123 and mpg321 should work. Though to be honest I rarely test the 123 commands, I recommend using either gstreamer or mpv/mplayer, the main reason the 123 commands are there is because I started with them.

MountainX commented 2 years ago

Yes both mpg123 and mpg321 should work. Though to be honest I rarely test the 123 commands, I recommend using either gstreamer or mpv/mplayer, the main reason the 123 commands are there is because I started with them.

Thank you. I wondered what was the best. I will stick with gstreamer. We can close this issue now.