squgeim / yt-ad-autoskipper

A browser extension that automates skipping ad on Youtube. This is not an ad blocker, it just automates the process of clicking on the "Skip Ad" button on Youtube.
https://chrome.google.com/webstore/detail/youtube-ad-auto-skipper/lokpenepehfdekijkebhpnpcjjpngpnd
GNU General Public License v3.0
270 stars 56 forks source link

Does not work with new Skip Ads box #31

Closed LewisSpring closed 3 years ago

LewisSpring commented 3 years ago

Hello there, since very recently, the extension does not work anymore. It seems to have coninsided with the new Skip Ads button, which looks like this. image image

Microsoft Edge Version 85.0.564.63 (Official build) (64-bit) Windows 10 2004

Thank you!

bkjoel commented 3 years ago

Next time this happens can you take a screenshot of the DOM focused on that btn? that way it could be tailored to that specific implementation of the "Skip ad" btn.

LewisSpring commented 3 years ago

Would you mind explaining how I’d do that? I had a look, but wasn’t too sure Thanks!

On 10 Oct 2020, at 06:24, bkjoel notifications@github.com wrote:

 Next time this happens can you take a screenshot of the DOM focused on that btn? that way it could be tailored to that specific implementation of the "Skip ad" btn.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bkjoel commented 3 years ago

Sure, here are a few different ways to do it - https://developers.google.com/web/tools/chrome-devtools/dom

On Sat, Oct 10, 2020 at 9:29 PM thelewiss1 notifications@github.com wrote:

Would you mind explaining how I’d do that? I had a look, but wasn’t too sure Thanks!

On 10 Oct 2020, at 06:24, bkjoel notifications@github.com wrote:

 Next time this happens can you take a screenshot of the DOM focused on that btn? that way it could be tailored to that specific implementation of the "Skip ad" btn.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/squgeim/yt-ad-autoskipper/issues/31#issuecomment-706591997, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGUZSPVEN2DKORHXI6DC7W3SKCRZXANCNFSM4R7SBSHA .

LewisSpring commented 3 years ago

It's now started working? I'm not entirely sure why. I'll let you know if it happens again!

Edit: On further reflection, I think I had the extension set to only work on certain pages, and I had reinstalled it before trying to check the DOM. I must've had the wrong pages allowed or something . I'll allow it to all from now on