search

squid-box / SevenZipSharp

Fork of SevenZipSharp on CodePlex
GNU Lesser General Public License v3.0
265 stars 99 forks source link

NuGet package Squid-Box.SevenZipSharp 1.5.0.366 includes DLLs with version 1.0.0.0 #152

Open Toqe opened 2 years ago

Toqe commented 2 years ago

I'm using the NuGet package Squid-Box.SevenZipSharp in a .NET 4.8 application that is deployed via MSI. After updating from NuGet package version 1.3.283 to 1.5.0.366 I noticed a strange behaviour in the update process of my application. This is caused by the versions of the 1.5.0.366 package being all set to 1.0.0.0, whereas the versions were set correctly in the old version:

File squid-box.sevenzipsharp.1.5.0.366\lib\net45\SevenZipSharp.dll Assembly name SevenZipSharp, Version=1.0.0.0, Culture=neutral, PublicKeyToken=c8ff6ba0184838bb

[assembly: AssemblyCompany("Markovtsev Vadim")]
[assembly: AssemblyConfiguration("Release")]
[assembly: AssemblyCopyright("Copyright (C) Markovtsev Vadim 2009, 2010, licensed under LGPLv3")]
[assembly: AssemblyDescription("7-zip native library wrapper")]
[assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0")]
[assembly: AssemblyProduct("SevenZipSharp")]
[assembly: AssemblyTitle("SevenZipSharp")]
[assembly: AssemblyVersion("1.0.0.0")]
(...)

File squid-box.sevenzipsharp.1.3.283\lib\net45\SevenZipSharp.dll Assembly name SevenZipSharp, Version=1.3.283.0, Culture=neutral, PublicKeyToken=c8ff6ba0184838bb

[assembly: AssemblyCompany("Markovtsev Vadim")]
[assembly: AssemblyConfiguration("Release")]
[assembly: AssemblyCopyright("Copyright (C) Markovtsev Vadim 2009, 2010, licenced under LGPLv3")]
[assembly: AssemblyDescription("7-zip native library wrapper")]
[assembly: AssemblyFileVersion("1.3.283.0")]
[assembly: AssemblyInformationalVersion("1.0.0")]
[assembly: AssemblyProduct("SevenZipSharp")]
[assembly: AssemblyTitle("SevenZipSharp")]
[assembly: AssemblyVersion("1.3.283.0")]
(...)

It seems AppVeyor is used to build the NuGet packages and after a quick Googling the config should also look good with dotnet_csproj/patch (although I have to admit that I have no experience with AppVeyor). Do you have any idea where the problem could come from or could I somehow assist fixing it?

Toqe commented 2 years ago

Ah, I see you've been already addressing the issue with 3b5351a11e8a90cdbb58a44c4caf8b92813d098e in the dev-branch, thanks!