Upgraded Dependencies and Added Tests to CI

shirblc commented 2 years ago

Summary of changes:

Upgraded all non-Webpack and non-Jasmine dependencies. Webpack 5+ seems to be clashing with Karma plugins; Jasmine dependencies can't be upgraded since karma-jasmine still wasn't updated to use Jasmine 4. (Might be worth considering deleting Jasmine from dev dependencies, since it's a dependency of karma-jasmine anyway.)
Deleted Sauce Labs configuration and removed it from Karma configurations.
Deleted Sauce Labs Karma launcher.
Added tests and integration tests to CI.
Added multiple node versions to CI, starting with Node 12. (Node 10 reached EOL, and Node 12 will reach EOL this month, so I figured it's probably okay to require the minimum version to be 12, rather than 10. That said, can always switch it back, though I think a couple of the packages might require downgrading.)

Haven't enabled codecov as I don't have the credentials, but otherwise I've tested it both locally and in GitHub Actions, and all appeared to be working correctly. Only other thing is, I don't think there's full support for all the browsers previously listed in the Sauce Labs configuration... we might have change the environment to run tests against pre-Chromium Edge (based on this)

Closes #659

squidfunk commented 2 years ago

Thanks for this PR! Awesome work! I agree with all points you mentioned and say that it's good to merge.

Only other thing is, I don't think there's full support for all the browsers previously listed in the Sauce Labs configuration... we might have change the environment to run tests against pre-Chromium Edge (based on https://github.com/actions/virtual-environments/issues/97)

As mentioned in #659 I think it's okay to switch to the headless strategy, which should yield much more stable builds. SauceLabs led to very flaky tests. If a we find that karma-viewport breaks in a browser it should support, we'll just fix it on the way. Being a dev dependency, it's not critical anyway.

Would you like to be a collaborator of this project? My time to spend here is very limited, and given the great work you've done here, I'm happy to add you as collaborator, so you can fix issues as they appear. Just ping me then and I'll issue a new release (which I will also do in a minute)

squidfunk commented 2 years ago

1.0.9 was released.

shirblc commented 2 years ago

Amazing, thank you!

squidfunk / karma-viewport

Upgraded Dependencies and Added Tests to CI #660