squidfunk / mkdocs-material

Documentation that simply works
https://squidfunk.github.io/mkdocs-material/
MIT License
20.19k stars 3.47k forks source link

Some tables with images aren't converting to html tables #143

Closed HerbFargus closed 7 years ago

HerbFargus commented 7 years ago

Description

I had some tables that rendered properly:

(the controller diagrams right above the hotkeys header)

https://retropie.github.io/RetroPie-Docs/First-Installation/#hotkeys

But now they don't render

https://retropie.org.uk/docs/First-Installation/#hotkeys

Here's a diff of the two pages: line 2441 (I made some edits to the content but you can see that the tables are not being generated for the new one)

https://www.diffchecker.com/jl9OuF3L

Steps to Reproduce:

Create table with image in it eg

|table with image|
| :---: |
| ![blue_pc_icon](https://cloud.githubusercontent.com/assets/10035308/22727034/7d475af2-ed8b-11e6-87bf-0872a2cd006f.png)|

Package versions

Project configuration

site_name: RetroPie Docs
theme: material

extra:
  logo: 'images/logo.svg'
  palette:
    primary: 'red'
    accent: 'red'
  social:
    - type: 'github'
      link: 'https://github.com/RetroPie'
    - type: 'twitter'
      link: 'https://twitter.com/retropieproject'

extra_css:
  - 'stylesheets/extra.css'

google_analytics:
  - 'UA-76418872-1'
  - 'auto'

repo_name: 'RetroPie-Setup'
repo_url: 'https://github.com/RetroPie/RetroPie-Setup'

copyright: 'Copyright © 2017 The RetroPie Project'

pages:
- Home: index.md
- First Installation: First-Installation.md
- Getting Started:
    - Controller Configuration: Controller-Configuration.md
    - Transferring Roms: Transferring-Roms.md
    - Runcommand: Runcommand.md
    - Scraper: Scraper.md
    - Themes: Themes.md
    - Updating RetroPie: Updating-RetroPie.md
    - SSH: SSH.md
    - Wifi: Wifi.md
- Arcade:
    - Arcade Quick Start: Arcade.md
    - MAME: MAME.md
    - lr-mame2003: lr-mame2003.md
    - FinalBurn Alpha: FinalBurn-Alpha.md
    - lr-fbalpha: lr-fbalpha.md
    - Neo Geo: Neo-Geo.md
    - Validating, Rebuilding, and Filtering Arcade ROMs: Validating,-Rebuilding,-and-Filtering-Arcade-ROMs.md
- Emulators:
    - 3do: 3do.md
    - Amiga: Amiga.md
    - Amstrad CPC: Amstrad-CPC.md
    - Apple II: Apple-II.md
    - Atari 2600: Atari-2600.md
    - Atari 7800: Atari-7800.md
    - Atari 800 and 5200: Atari-800-and-5200.md
    - Atari Jaguar: Atari-Jaguar.md
    - Atari Lynx: Atari-Lynx.md
    - Atari ST-STE-TT-Falcon: Atari-ST-STE-TT-Falcon.md
    - Coco: Coco.md
    - Colecovision: Colecovision.md
    - Commodore 64: Commodore-64.md
    - Daphne: Daphne.md
    - Dragon: Dragon.md
    - Dreamcast: Dreamcast.md
    - Game Boy Advance: Game-Boy-Advance.md
    - Game Boy Color: Game-Boy-Color.md
    - Game Boy: Game-Boy.md
    - GameCube: GameCube.md
    - Game Gear: Game-Gear.md
    - Game & Watch: Game-&-Watch.md
    - GemRB: GemRB.md
    - Genesis/Megadrive: Genesis-Megadrive.md
    - Intellivision: Intellivision.md
    - Love: Love.md
    - Macintosh: Macintosh.md
    - Master System: Master-System.md
    - MESS: MESS.md
    - MSX: MSX.md
    - Neo Geo Pocket Color: Neo-Geo-Pocket-Color.md
    - Neo Geo Pocket: Neo-Geo-Pocket.md
    - Nintendo 64: Nintendo-64.md
    - Nintendo DS: Nintendo-DS.md
    - Nintendo Entertainment System: Nintendo-Entertainment-System.md
    - OpenBOR: OpenBOR.md
    - Oric: Oric.md
    - PC Engine: PC-Engine.md
    - PC: PC.md
    - Playstation 1: Playstation-1.md
    - Playstation 2: Playstation-2.md
    - PSP: PSP.md
    - Sam Coupe: Sam-Coupe.md
    - Saturn: Saturn.md
    - ScummVM: ScummVM.md
    - Sega 32X: Sega-32X.md
    - Sega CD: Sega-CD.md
    - SG 1000: SG-1000.md
    - Super Nintendo Entertainment System: Super-Nintendo-Entertainment-System.md
    - TI-99: TI-99.md
    - TRS-80: TRS-80.md
    - Vectrex: Vectrex.md
    - VideoPac / Odyssey 2: VideoPac-Odyssey-2.md
    - Virtual Boy: Virtual-Boy.md
    - Wii: Wii.md
    - Wonderswan Color: Wonderswan-Color.md
    - WonderSwan: WonderSwan.md
    - Zmachine: Zmachine.md
    - ZX Spectrum: ZX-Spectrum.md
- Ports: 
    - Adventure Game Studio: Adventure-Game-Studio.md
    - Cannonball: Cannonball.md
    - CaveStory: CaveStory.md
    - Commander Keen: Commander-Keen.md
    - Descent: Descent.md
    - Dinothawr: Dinothawr.md
    - Doom: Doom.md
    - Duke Nukem 3D: Duke-Nukem-3D.md
    - GameMaker Games: GameMaker-Games.md
    - KODI: KODI.md
    - Limelight: Limelight.md
    - Lincity: Lincity.md
    - Marathon: Marathon.md
    - Micropolis: Micropolis.md
    - Minecraft: Minecraft.md
    - OpenTTD: OpenTTD.md
    - OpenTyrian: OpenTyrian.md
    - Ports: Ports.md
    - Quake: Quake.md
    - ResidualVM: ResidualVM.md
    - SDLPoP: SDLPoP.md
    - Solarus: Solarus.md
    - Stratagus: Stratagus.md
    - Super Mario War: Super-Mario-War.md
    - SuperTux: SuperTux.md
    - The Ur Quan Masters: The-Ur-Quan-Masters.md
    - Wolfenstein 3D: Wolfenstein-3D.md
    - Xrick: Xrick.md
- Controllers:
    - Xbox 360: Xbox-360-Controller.md
    - PS3: PS3-Controller.md
    - 8Bitdo: 8Bitdo-Controller.md
    - Bluetooth: Bluetooth-Controller.md
    - Logitech: Logitech-Controller.md
    - N64: N64-Controller.md
    - PS4: PS4-Controller.md
    - Ouya: Ouya-Controller.md
    - Xiaomi: Xiaomi-Controller.md
    - Xin-Mo: Xin-Mo-Controller.md
    - Spinners and Trackballs: Spinners-and-Trackballs.md
    - Mobile Gamepad: Mobile-Gamepad.md
    - Virtual Gamepad: Virtual-Gamepad.md
    - Wii U Pro: Wii-U-Pro-Controller.md
    - Wiimotes: Wiimote-Controller.md
    - GPIO Modules: GPIO-Modules.md
- Advanced Configuration:
    - BIOS: BIOS.md
    - Changelogs: Changelogs.md
    - Configuration Editor: Configuration-Editor.md
    - Memory Split: Memory-Split.md
    - Overclocking: Overclocking.md
    - Optimization for Nintendo 64: Optimization-for-Nintendo-64.md
    - Running ROMs from a Network Share: Running-ROMs-from-a-Network-Share.md
    - Running ROMs from a USB drive: Running-ROMs-from-a-USB-drive.md
    - Splashscreen: Splashscreen.md
    - Supported Systems: Supported-Systems.md
    - Take and Scrape Your Own Screenshots: Take-and-Scrape-Your-Own-Screenshots.md
    - Mapping a Controller for Intellivision: Mapping-a-Controller-for-Intellivision.md
    - Universal Controller Calibration & Mapping Using xboxdrv: Universal-Controller-Calibration-&-Mapping-Using-xboxdrv.md
- RetroArch:
    - RetroArch: RetroArch.md
    - RetroArch Controller Configuration: RetroArch-Configuration.md
    - RetroAchievements: RetroAchievements.md
    - Netplay: Netplay.md
    - Shaders and Smoothing: Shaders-and-Smoothing.md
    - Smaller RetroArch Screen: Smaller-RetroArch-Screen.md
- EmulationStation:
    - EmulationStation: EmulationStation.md
    - Child friendly EmulationStation: Child-friendly-EmulationStation.md
    - Creating Your Own EmulationStation Theme: Creating-Your-Own-EmulationStation-Theme.md
    - Add a New System in EmulationStation: Add-a-New-System-in-EmulationStation.md
- Platforms:
    - Raspbian: Manual-Installation.md
    - Ubuntu: RetroPie-Ubuntu-16.04-LTS-x86-Flavor.md
    - Odroid: Odroid.md
    - Arch Linux: RetroPie-Arch-Linux-Flavor.md
    - OSMC: RetroPie-install-for-OSMC-with-external-memory-USB-Drive.md
- Troubleshooting:
    - FAQ: FAQ.md
    - Sound Issues: Sound-Issues.md
    - Speed Issues: Speed-Issues.md
    - Video Issues: Video-Issues.md
- Developers:
    - Building RetroPie Archives: Building-RetroPie-Archives.md
    - Convert RetroPie SD Card Image to NOOBS Image: Convert-RetroPie-SD-Card-Image-to-NOOBS-Image.md
    - Shell Style Guide: Shell-Style-Guide.md

System information

squidfunk commented 7 years ago

Can you post or link to the Markdown source which causes the problem?

facelessuser commented 7 years ago

Are those single column tables? If so, there was a regression in the latest Python Markdown which killed single column tables. A number of bugs were fixed, but I broke single column tables in the process. I submitted a fix, but I don't know when the next bug fix release will drop that has that fix.

HerbFargus commented 7 years ago

This is the source: https://github.com/retropie/retropie-setup/wiki/First-Installation#hotkeys

But yes it is a single column table so likely the issue mentioned by @facelessuser.

Posted here for reference: https://github.com/waylan/Python-Markdown/pull/540

Wasn't sure if it was a material or mkdocs or Python markdown issue. But since this isnt a material theme issue I will close this and update Python markdown or patch it locally.

Thanks!

HerbFargus commented 7 years ago

Just posting to confirm that rolling back the python markdown fixed the issue. all is well.

thanks again :)