Ligatures being rendered on inline/block code elements

layoaster commented 2 years ago

Contribution guidelines

[X] I've read the contribution guidelines and wholeheartedly agree

I've found a bug and checked that ...

[X] ... the problem doesn't occur with the mkdocs or readthedocs themes
[X] ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem

Description

The issue got fixed long time ago but it's happening again. It affects both block & inline code elements.

Expected behaviour

Have monospaced fonts rendered without ligatures like on github:

<region>-realtime

Druid datasource
`<region>-realtime`

Actual behaviour

Ligatures are being rendered:

Steps to reproduce

Using JetBrains Mono for code elements.
Input any pair of characters like -> or -< ligature in a block of code or inline.

Package versions

Python: python --version: 3.9.13
MkDocs: mkdocs --version: 1.3.1
Material: pip show mkdocs-material | grep -E ^Version: 8.5.2

Configuration

site_name: "EA"
site_url: null
repo_name: null
repo_url: null
edit_uri: null

theme:
  name: material
  # Colors
  palette:
    - scheme: default
      toggle:
        icon: material/lightbulb-outline
        name: Switch to dark mode
      primary: indigo
      accent: blue
    - scheme: slate
      toggle:
        icon: material/lightbulb
        name: Switch to light mode
      primary: brown
      accent: orange
  # Fonts
  font:
    text: Roboto
    code: JetBrains Mono

  features:
    - navigation.instant
    - navigation.sections
    - navigation.tabs
    - navigation.expand
    - navigation.top
    - search.suggest
    - search.highlight
    - toc.integrate

System information

Operating system: Linux/Ubuntu
Browser: Firefox

squidfunk commented 2 years ago

Thanks for reporting. Indeed, that's unintended. Fixed in dcab57dd1.

squidfunk commented 2 years ago

By the way, funnily, monospace fonts still have no "liga" set on font-feature-settings:

https://github.com/squidfunk/mkdocs-material/blob/dcab57dd1cced4b77875c1aa1b53467c62709d31/src/assets/stylesheets/main/_typeset.scss#L56

So, effectively, we changed nothing for the last 5 years 😅

squidfunk commented 2 years ago

Released as part of 8.5.3.

squidfunk / mkdocs-material