squidowl / halloy

IRC application written in Rust
GNU General Public License v3.0
1.18k stars 40 forks source link

Message Tags Support #366

Closed andymandias closed 2 months ago

andymandias commented 2 months ago

Reading through message-tags and looking at irc/proto/src/parse.rs I believe tags are already rigorously parsed by the current implementation. I believe all we need in addition to that is support for the CLIENTTAGDENY ISUPPORT parameter and TAGMSG command.

In the client-only tags registry there appears to be one active and three draft client-only tags. If/when we implement those features I believe we should disable them if they're covered in the CLIENTTAGDENY ISUPPORT parameter, but as it stands (with none of those features implemented, yet) I think parsing CLIENTTAGDENY (added in #349) should be sufficient.

This PR adds the TAGMSG command. As with CLIENTTAGDENY there's nothing for us to utilize TAGMSG for yet, so I think its addition is all we currently need.

tarkah commented 2 months ago

Makes sense, thanks!