search

squidowl / halloy

IRC application written in Rust
GNU General Public License v3.0
1.66k stars 63 forks source link

Password command not working for SASL #580

Closed heksesang closed 1 month ago

heksesang commented 1 month ago

According to the documentation, it should be possible to configure password_command for servers.<servername>.sasl.plain: https://halloy.squidowl.org/configuration/servers/sasl/plain.html

When I try to do so, I get an error when starting the client that there is no such configuration option, and also looking at the source code I cannot see any such option in the configuration struct.

casperstorm commented 1 month ago

@4e554c4c Do you have any insight as you recently added password_command?

4e554c4c commented 1 month ago

Yes, this was me mistakingly adding that documentation when the configuration option only exists for servers. It should be pretty easy to add to SASL though

casperstorm commented 1 month ago

If you have capacity, and feel like something you want to tackle, then just let me know @4e554c4c. Thanks for the update.

4e554c4c commented 1 month ago

yep, taking a look :smiley: