search

squidy5 / cargo_ships

factorio mod that adds cargo ships and other content to the game
25 stars 39 forks source link

Oil rigs fail on surfaces other than Nauvis #52

Closed robot256 closed 3 years ago

robot256 commented 3 years ago

When using Space Exploration to generate other surface worlds with bodies of water, oil rigs do not build properly. There are still a few lines of code that use game.surfaces[1] instead of entity.surface.

robot256 commented 3 years ago

Tested working fixed in this branch: https://github.com/robot256/cargo_ships/tree/actual_0-57

I can make a pull request once you upload version 0.0.57 to your repo.

squidy5 commented 3 years ago

Thanks for your contributions and sorry for not replying. I havent really been very active regarding this project latley. I updated the repository to the current version, and merged the pull request you made a few weeks ago. Maybe the issue is already resolved then? If not I d be happy to merge any further pull request!

robot256 commented 3 years ago

The fix for this one was more involved, so I'll make another pull request. Glad to help!

robot256 commented 3 years ago

Turns out my fix for this got rolled into the other pull request already. There was one new change that wasn't (not mandatory but nice to have) that I made a new PR for just now. This issue is closed now. Thanks!