search

squigg / azure-queue-laravel

PHP Laravel Queue Driver package for Microsoft Azure Storage Queues
41 stars 24 forks source link

Implementing the register method in the service provider for compatibility with Laravel/Lumen 5.2 #3

Closed EricTendian closed 7 years ago

EricTendian commented 7 years ago

This is an update to #2 - I was just testing the package on Lumen 5.2, and got the error Class Squigg\AzureQueueLaravel\AzureQueueServiceProvider contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Support\ServiceProvider::register)

Apparently register() was made non-abstract for 5.3: https://github.com/laravel/framework/commit/56b52c2e94f211bb04c52e8f1971432969784bab - because of that, the service provider update doesn't work on 5.2. Had to add it back to the service provider for it to work.

Sorry I didn't catch this in my original PR! Hopefully this can get in before backporting.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 98.182% when pulling cc4407d003bceb7add0fdd8b04f8e1ae2f27ce34 on EricTendian:master into 4f29ab17c9a08512a5931a781511ab215ab0e515 on squigg:master.

squigg commented 7 years ago

Thanks.

I had fortunately already picked this up for 5.2 during the phpunit testing. Was just setting up a proper Laravel install to test with a live Azure connection before pushing to make sure everything works nicely.

Will leave out of the master branch as it's no longer required, and just add this back into 5.2 only.

Keep them coming if you find anything else! :)