search

squint-cljs / compiler-common

Common code for squint and cherry
14 stars 3 forks source link

Fix issue with esm import on MS-Windows #19

Closed ikappaki closed 1 year ago

ikappaki commented 1 year ago

Hi,

could you please review PR to fix issue with esm import file names on MS-Windows. It fixes https://github.com/squint-cljs/squint/issues/277

The fix is to convert all filenames to urls, since this is the canonical input argument of esm import.

It also

  1. Removes the source-maps dev dependency from package.json since it can't compile on MS-Windows with latest tooling and is currently unused (see https://github.com/squint-cljs/squint/issues/278)
  2. Renames node.js to node-api.js since the first will be executed by scripts instead of node.exe on MS-windows.
  3. Includes MS-Windows coverage in CI.

Thanks