squint-cljs / compiler-common

Common code for squint and cherry
14 stars 3 forks source link

cherry install has resolution to lower version #8

Closed alidcast closed 1 year ago

alidcast commented 1 year ago

found cause of #7

For whatever reason there is a resolution for alpha.53. I don't have that set in codebase, nor could I find it in cherry or compiler code, or search. I'm opening an issue in case it may be accidentally set and you know where/why. Otherwise feel free to close as I'm going to override it on my end.

"cherry-cljs@npm:^0.0.0-alpha.60":
  version: 0.0.0-mutable-alpha.53
  resolution: "cherry-cljs@npm:0.0.0-mutable-alpha.53"
  dependencies:
    argparse: ^2.0.1
    lodash: ^4.17.21
  bin:
    cherry: node_cli.js
  checksum: 4665045e4b22fadc8cdf6a45003cff3c1050f8c27795f05d2c65c077ef6014c6b447a51a32c48e28ec048a450c1436da77e8e2ce34221cdcb8bdeb9b6602dbe4
  languageName: node
  linkType: hard
borkdude commented 1 year ago

Oh this is not good at all, it might be an older version of squint from when it wasn't called squint yet!

Did you get this by doing npm install cherry-cljs?

alidcast commented 1 year ago

for a netsted a yarn monorepo, I ran yarn install cherry-cljs

alidcast commented 1 year ago

https://github.com/squint-cljs/cherry/blob/b505ce4a856d35fdb942560182b328c25971d7de/package.json#L25-L27

I think this is the cause..

was just install cherry pinned to latest and it is failing bc

 YN0000: ┌ Resolution step
➤ YN0002: │ cherry-cljs@npm:0.0.0-alpha.60 doesn't provide @babel/core (pcaaa7), requested by @babel/preset-react

so may be why another version ends up resolved

borkdude commented 1 year ago

Ah darn, that should be a dev dependency

borkdude commented 1 year ago

PR welcome

alidcast commented 1 year ago

sorry i don't have the other repo setup for such a small fix otherwise i would. but did want to post update

borkdude commented 1 year ago

Fixed in compiler-common