search

squint-cljs / vite-plugin-squint

A plugin to compile .cljs source code with squint using vite
1 stars 3 forks source link

HMR Support #13

Closed brandonstubbs closed 4 months ago

brandonstubbs commented 5 months ago

This fixes the issues I was mentioning in #11 we were taking over the esbuild and trying to convert all the jsx. This should be left to the other plugins. All we do now is compile squint into JS and leave the other plugins to do their jobs. This also fixes HMR.

cc @martinklepsch

martinklepsch commented 4 months ago

Just tried this locally and ran into an error (this is in demo/react/)

Screenshot 2024-03-30 at 11 27 05

brandonstubbs commented 4 months ago

Great catch, I managed to reproduce after I cleared my vite cache. I pushed a fix. This happens during dependency scanning

martinklepsch commented 4 months ago

I got merge access from @borkdude, let me know when you think this is ready! (looks pretty much ready to me)

brandonstubbs commented 4 months ago

@martinklepsch I think it's ready to go