squirephp / squire

A library of static Eloquent models for common fixture data.

MIT License

1k stars 69 forks source link

Translate Country Names #3

Closed Jubeki closed 3 years ago

Jubeki commented 4 years ago

Capital cities were not translated. I used https://github.com/unicode-cldr/cldr-localenames-full for the translations.

1

danharrin commented 4 years ago

Thanks for your work here! ❤️

For v2, I will be restructuring the whole project, so from there, we can work on restructuring this PR to match.

Jubeki commented 4 years ago

Okay just comment on this PR and I will update it accordingly. 👍

Jubeki commented 4 years ago

@danharrin I just saw that you probably tagged the wrong version 30 minutes ago: Right now it is v1.2.0 instead of v0.2.0

You should probably tag the next big release as v2 instead of v1

danharrin commented 3 years ago

Hey! I've just released v2.0.0. This release brings major changes to the Squire ecosystem, including the split of models and their data sources into separate packages. As such, this PR will need updating to reflect this. If you're able to do this, that would be greatly appreciated! Feel free to open a new PR. I realise that this may take some time so don't worry if not :)