squirrel-labs / ratatosk

Rask is a platformer game built with WASM and Rust
https://rask.rocks
MIT License
15 stars 1 forks source link

Ratatosk #12 failed #13

Closed TrueDoctor closed 5 years ago

TrueDoctor commented 5 years ago

Build 'Ratatosk' is failing!

Last 50 lines of build output:

[...truncated 36.85 KB...]
   = note: #[warn(clippy::needless_lifetimes)] on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> client/shared/src/double_buffer.rs:68:5
   |
68 | /     pub fn borrow_writer<'a>(&'a mut self) -> WriterBufferView<'a, T> {
69 | |         let write_pos = match (self.get_reading_at(), self.get_provided()) {
70 | |             (0, 0) => 0,
71 | |             (0, y) => 2 - y,
...  |
74 | |         WriterBufferView { ptr: self, write_pos }
75 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: you should consider deriving a `Default` implementation for `wasm_log::WasmLog`
  --> client/shared/src/wasm_log.rs:21:5
   |
21 |     pub fn new() -> Self { WasmLog() }
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try this
   |
18 | #[derive(Default)]
   |

warning: unused attribute
  --> client/shared/src/double_buffer.rs:16:1
   |
16 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default

warning: unused attribute
  --> client/shared/src/double_buffer.rs:23:1
   |
23 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `webhogg-wasm-shared`.

To learn more, run the command again with --verbose.
Build step 'Run with timeout' marked build as failure

Changes since last successful build: No changes

View full output

TrueDoctor commented 5 years ago

Build 'Ratatosk' is failing!

Last 50 lines of build output:

[...truncated 36.87 KB...]
   = note: #[warn(clippy::needless_lifetimes)] on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> client/shared/src/double_buffer.rs:68:5
   |
68 | /     pub fn borrow_writer<'a>(&'a mut self) -> WriterBufferView<'a, T> {
69 | |         let write_pos = match (self.get_reading_at(), self.get_provided()) {
70 | |             (0, 0) => 0,
71 | |             (0, y) => 2 - y,
...  |
74 | |         WriterBufferView { ptr: self, write_pos }
75 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: you should consider deriving a `Default` implementation for `wasm_log::WasmLog`
  --> client/shared/src/wasm_log.rs:21:5
   |
21 |     pub fn new() -> Self { WasmLog() }
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try this
   |
18 | #[derive(Default)]
   |

warning: unused attribute
  --> client/shared/src/double_buffer.rs:16:1
   |
16 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default

warning: unused attribute
  --> client/shared/src/double_buffer.rs:23:1
   |
23 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `webhogg-wasm-shared`.

To learn more, run the command again with --verbose.
Build step 'Run with timeout' marked build as failure

Changes since last successful build: No changes No changes

View full output

TrueDoctor commented 5 years ago

Build 'Ratatosk' is failing!

Last 50 lines of build output:

[...truncated 47.12 KB...]
   | |_____^
   |
   = note: #[warn(clippy::needless_lifetimes)] on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: this loop could be written as a `while let` loop
  --> game_server/src/scribble_group.rs:54:9
   |
54 | /         loop {
55 | |             let message = match rec.recv_message() {
56 | |                 Ok(x) => x,
57 | |                 _ => break,
...  |
67 | |             }
68 | |         }
   | |_________^ help: try: `while let Ok(x) = rec.recv_message() { .. }`
   |
   = note: #[warn(clippy::while_let_loop)] on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop

warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
   --> game_server/src/server.rs:143:36
    |
143 |           std::thread::spawn(move || match Self::handle_requests(addr, &sen) {
    |  ____________________________________^
144 | |             Err(e) => sen.send(Err(e)).unwrap(),
145 | |             _ => (),
146 | |         });
    | |_________^ help: try this: `if let Err(e) = Self::handle_requests(addr, &sen) { sen.send(Err(e)).unwrap() }`
    |
    = note: #[warn(clippy::single_match)] on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match

warning: this loop could be written as a `while let` loop
  --> game_server/src/webhogg_group.rs:60:9
   |
60 | /         loop {
61 | |             let message = match rec.recv_message() {
62 | |                 Ok(x) => x,
63 | |                 _ => break,
...  |
73 | |             }
74 | |         }
   | |_________^ help: try: `while let Ok(x) = rec.recv_message() { .. }`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop

error: build failed
Build step 'Run with timeout' marked build as failure

Changes since last successful build: No changes No changes

View full output

TrueDoctor commented 5 years ago

Build was fixed!

TrueDoctor commented 5 years ago

Build 'Ratatosk' is failing!

Last 50 lines of build output:

[...truncated 47.42 KB...]
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> client/shared/src/double_buffer.rs:68:5
   |
68 | /     pub fn borrow_writer<'a>(&'a mut self) -> WriterBufferView<'a, T> {
69 | |         let write_pos = match (self.get_reading_at(), self.get_provided()) {
70 | |             (0, 0) => 0,
71 | |             (0, y) => 2 - y,
...  |
74 | |         WriterBufferView { ptr: self, write_pos }
75 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: you should consider deriving a `Default` implementation for `wasm_log::WasmLog`
  --> client/shared/src/wasm_log.rs:21:5
   |
21 |     pub fn new() -> Self { WasmLog() }
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try this
   |
18 | #[derive(Default)]
   |

warning: unused attribute
  --> client/shared/src/double_buffer.rs:16:1
   |
16 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default

warning: unused attribute
  --> client/shared/src/double_buffer.rs:23:1
   |
23 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `webhogg-wasm-shared`.

To learn more, run the command again with --verbose.
Build step 'Run with timeout' marked build as failure
GitHub Issue Notifier: Build has started failing again, reopend GitHub issue #13

Changes since last successful build:

View full output

TrueDoctor commented 5 years ago

Build was fixed!