squirrel-project / squirrel_driver

0 stars 14 forks source link

Interaction #131

Closed HPovoa closed 7 years ago

HPovoa commented 7 years ago

Refactored the Interaction components for Squirrel.

The main change is that all code will be ran from the Raspberry Pi (including serial communication with the interaction board)

ipa-nhg commented 7 years ago

@HPovoa please review https://github.com/HPovoa/squirrel_driver/pull/1 and merge if it is ok for you

ipa-nhg commented 7 years ago

@HPovoa please let me know when this is tested and working on the robot to merge the Pull Request Thanks!

HPovoa commented 7 years ago

Hi Nadia,

The code is working on the robot, I tested it yesterday but today I wanted to do a quick sweep in case i missed something.

There are still changes I want to make, but this is a good time to merge i think.

I would ask you to review the code where i publish to /joint_states, it is in board.py, because I am unsure if this is the correct way to do it.

Very best, Henrique Póvoa

2017-08-10 11:25 GMT+01:00 Nadia Hammoudeh García notifications@github.com :

@HPovoa https://github.com/hpovoa please let me know when this is tested and working on the robot to merge the Pull Request Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/squirrel-project/squirrel_driver/pull/131#issuecomment-321513350, or mute the thread https://github.com/notifications/unsubscribe-auth/AbjVJ_541db39zS8olHgKYdu373lcdaOks5sWtqdgaJpZM4OvWS0 .