search

squirrel-project / squirrel_perception

Repository for object perception related SQUIRREL packages.
3 stars 6 forks source link

added recognition #73

Closed mzillich closed 8 years ago

ipa-nhg commented 8 years ago

Build error:

[ 8%] Building CXX object squirrel_perception/squirrel_classification/CMakeFiles/squirrel_classification.dir/src/shape_simple_classifier_node.cpp.o In file included from /opt/ros/indigo/include/v4r/recognition/mesh_source.h:33:0, from /tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_classification/src/shape_simple_classifier_node.cpp:25: /opt/ros/indigo/include/v4r/common/miscellaneous.h: In function 'std::vector v4r::filterVector(const std::vector&, const std::vector&)': /opt/ros/indigo/include/v4r/common/miscellaneous.h:429:21: error: ISO C++ forbids declaration of 'idx' with no type [-fpermissive] for(const auto &idx : indices) ^ /opt/ros/indigo/include/v4r/common/miscellaneous.h:429:27: error: range-based 'for' loops are not allowed in C++98 mode for(const auto &idx : indices) ^ make[2]: * [squirrel_perception/squirrel_classification/CMakeFiles/squirrel_classification.dir/src/shape_simple_classifier_node.cpp.o] Error 1 make[1]: * [squirrel_perception/squirrel_classification/CMakeFiles/squirrel_classification.dir/all] Error 2

bajo commented 8 years ago

@mzillich @ipa-nhg Can you please test it with this package squirrel_perception/ros-indigo-v4r_1.3.1-0trusty-20160113-1651-+0000_amd64.deb instead of the ros-indigo-v4r_1.4.0-0trusty-20160127-1419-+0000_amd64.deb which was used on the build bot server? I guess that a recent change in the v4r package is the cause of this build error. Thanks.

bajo commented 8 years ago

@mzillich I found the commit that causes the trouble. https://rgit.acin.tuwien.ac.at/root/v4r/commit/ffbafcc13b175168527d7280fe11972024929e9f

As indigo is not targeting c++11 features by default (and is not encouraging users to do so) we can either change the code in v4r to be c++03 compatible, or follow this suggestion http://answers.ros.org/question/152276/is-there-a-way-to-enable-c11-support-for-catkin-packages/ .

mzillich commented 8 years ago

Hi, Simon and I also found the offending file. I send an issue to Thomas on rgit to fix it. Just two lines.

bajo commented 8 years ago

@mzillich Can you update the recognizer to follow the new interface in v4r? Thanks

bajo commented 8 years ago

@mzillich Code compiles now, As soon as you changed the Readme I will merge it.

ipa-nhg commented 8 years ago

Thanks! @bajo @mzillich