search

squirrel-project / squirrel_perception

Repository for object perception related SQUIRREL packages.
3 stars 6 forks source link

Install tags missed #79

Open ipa-nhg opened 8 years ago

ipa-nhg commented 8 years ago

Please review the packages , I saw that you have defined a lot of folders inside each packages that are not listed on the CMakeLists.

Take a look at http://wiki.ros.org/catkin/CMakeLists.txt the section 10. Optional Step: Specifying Installable Targets . It is optional but if you dont define the folders like data in squirrel_object_perception , this folder will be ignored when you release your package. A simple example can be found on squirrel_robotino for meshes and urdf folders https://github.com/squirrel-project/squirrel_robotino/blob/indigo_dev/robotino_description/CMakeLists.txt#L12

bajo commented 8 years ago

@ipa-nhg Thank you, I did not know that. So I need to add folders like squirrel_object_perception/data/octomaps/ and squirrel_perception/rosdep as an Installable Target ?

ipa-nhg commented 8 years ago

yes, with squirrel_object_perception/data is enough.

You can see the result with the command _catkinmake install , the install folder that will be generated with this command, is the version that you will generate when you release your package.

Actually, I usually source the catkin_ws/install/setup.bash to use the release version and be sure that nothing is missed.

PS: This issue is not critical