search

squirrel-project / squirrel_perception

Repository for object perception related SQUIRREL packages.
3 stars 6 forks source link

octomap dilation, remove hard coded leaf size #81

Closed edith-langer closed 8 years ago

bajo commented 8 years ago

@edith-langer This pr fails to build on buildbot. http://3355f4e5.ngrok.com/builders/squirrel_perception_indigo_prtestbuild/builds/36/steps/squirrel_perception-build/logs/stdio error: 'squirrel_waypoint_msgs::ExamineWaypointRequest' has no member named 'bounding_cylinder' Is there an update for squirrel_common missing here?

mzillich commented 8 years ago

this will work, once the squirrel_common PR is through..

bajo commented 8 years ago

ok. I will check it later if this already builds fine before merging it.

bajo

On Wed, 2 Mar 2016 at 16:47 Michael Zillich notifications@github.com wrote:

this will work, once the squirrel_common PR is through..

— Reply to this email directly or view it on GitHub https://github.com/squirrel-project/squirrel_perception/pull/81#issuecomment-191295082 .

Dipl.-Ing. Markus Bajones, BSc

ACIN Automation and Control Institute Vienna University of Technology (DVR-Number 0005886)

Gusshausstr 27-29/E376, 1040 Vienna, Austria bajones@acin.tuwien.ac.at Tel: +43 1 58801 376633 Fax: +43 1 58801 9376633

ipa-nhg commented 8 years ago

The squirrel_common changes are needed , I am already updating the repository

ipa-nhg commented 8 years ago

@edith-langer something is wrong builtbot says:


/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_find_dynamic_objects_server.cpp:117:22: error: 'squirrel_object_perception_msgs::FindDynamicObjects::Response' has no member named 'dynamic_objects'
             response.dynamic_objects.push_back(lump);

See https://github.com/edith-langer/squirrel_perception/blob/indigo_stable/squirrel_object_perception/src/squirrel_find_dynamic_objects_server.cpp#L117 and https://github.com/squirrel-project/squirrel_common/commit/1c19d7b9325cc5242be7ca9c05422bd3f91fd6d6

edith-langer commented 8 years ago

Please try again now!

ipa-nhg commented 8 years ago

if currentOctomapPath is not needed , please remove or comment all the code lines that use it.

Thanks!

edith-langer commented 8 years ago

Actually, I already did that with the small fix commit... It is not used anymore. https://github.com/edith-langer/squirrel_perception/blob/indigo_stable/squirrel_object_perception/src/squirrel_find_dynamic_objects_server.cpp#L21

ipa-nhg commented 8 years ago

I get a new error:

/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:217:19: error: 'squirrel_planning_knowledge_msgs::AddObjectService::Request' has no member named 'id'
       srv.request.id = object.id;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:218:19: error: 'squirrel_planning_knowledge_msgs::AddObjectService::Request' has no member named 'category'
       srv.request.category = object.category;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:219:19: error: 'squirrel_planning_knowledge_msgs::AddObjectService::Request' has no member named 'pose'
       srv.request.pose = object.pose;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:220:19: error: 'squirrel_planning_knowledge_msgs::AddObjectService::Request' has no member named 'cloud'
       srv.request.cloud = object.points;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp: In member function 'bool LookForObjectsAction::update_object_in_db(Object)':
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:291:19: error: 'squirrel_planning_knowledge_msgs::UpdateObjectService::Request' has no member named 'id'
       srv.request.id = object.id;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:292:19: error: 'squirrel_planning_knowledge_msgs::UpdateObjectService::Request' has no member named 'category'
       srv.request.category = object.category;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:293:19: error: 'squirrel_planning_knowledge_msgs::UpdateObjectService::Request' has no member named 'pose'
       srv.request.pose = object.pose;
                   ^
/tmp/squirrel_perception_indigo_prtestbuild/src/squirrel_perception/squirrel_object_perception/src/squirrel_look_for_objects_server.cpp:294:19: error: 'squirrel_planning_knowledge_msgs::UpdateObjectService::Request' has no member named 'cloud'
       srv.request.cloud = object.points;

@mzillich I think that squirrel_look_for_objects should be updated according to https://github.com/squirrel-project/squirrel_common/pull/98

ipa-nhg commented 8 years ago

Now is working! Thank you so much @edith-langer @bajo if it is also right for you , you can merge the pull request

mzillich commented 8 years ago

LGTM (bajo is in a plane above the indian ocean right now :)

ipa-nhg commented 8 years ago

Ok! :) I will merge it

mzillich commented 8 years ago

Oh I see there are conflicts. @ipa-rmb can you fix these? I am at the winter shool right now and barely have time to clean my mail backlog ..

ipa-nhg commented 8 years ago

I sent a pull request to @edith-langer that should solve the merge conflict https://github.com/edith-langer/squirrel_perception/pull/1