All the changes we made last year.

Morloth1274 commented 7 years ago

Sorry for postponing this forever, but here is the pull request. The branch contains all the code we used for the 3rd year review.

Morloth1274 commented 7 years ago

Should be good to go now I think.

Morloth1274 commented 7 years ago

I think so yes. I'll look into this :).

On Tue, Jun 20, 2017 at 1:57 PM, Nadia Hammoudeh García < notifications@github.com> wrote:

@ipa-nhg commented on this pull request.

In squirrel_interface_manipulation/src/RPGraspAction.cpp https://github.com/squirrel-project/squirrel_planning/pull/59#discussion_r122966906 :
        // dispatch Grasp action
squirrel_manipulation_msgs::BlindGraspGoal goal; goal.heap_center_pose = poseMap;

goal.heap_center_pose_static = object_wp;
error: ‘squirrel_manipulation_msgs::BlindGraspGoal’ has no member named ‘heap_center_pose_static’

may a pull request to squirrel_common is missed... (?)

See https://github.com/squirrel-project/squirrel_common/blob/ indigo_dev/squirrel_manipulation_msgs/action/BlindGrasp.action

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/squirrel-project/squirrel_planning/pull/59#pullrequestreview-45126068, or mute the thread https://github.com/notifications/unsubscribe-auth/AIWMcEbjGKMtOFSkWD-XsJTWhlbr0tFZks5sF8G0gaJpZM4N-g9T .

-- Dr Bram Ridder Research Associate Department of Informatics, King's College London http://www.inf.kcl.ac.uk/pg/bram/

Morloth1274 commented 7 years ago

I've created a pull request on the squirrel_common branch. That should solve this problem.

squirrel-project / squirrel_planning

All the changes we made last year. #59

@ipa-nhg commented on this pull request.