(KCL) Changes from integration meeting

[m312z]

Changed package names and added meta package. Added unit test stubs. Removed some temporary hacks from the SQUIRREL summer school.

[ipa-jsf]

@m312z Could you please correct the following:

1. In squirrel_planning_system: All .h header files must go into the folder include/squirrel_planning_system/ . Please adapt all your paths in the dependend cpp files as well. Sorry, but that's the ROS convention.
2. The metapackage has runtime dependencies to non-existing packages
3. There are .jcc, .jst, .jup, .lex, .yacc, .cacc files. I'm not familiar with these filetypes. If they are not needed for code compliation, please move them to another folder e.g. common/files/
4. Makefiles in src/ folder shouldn't be needed
5. All the rest looks OK

Please incorporate my remarks and send me an updated pull request as soon as possible to keep our deadlines. I know this work is annoying, but it surely will pay off at the end.

[m312z]

@ipa-jsf

1. I assume the same is true for squirrel_knowledge_base? I have moved all except for those in squirrel_planning_system/src/VALFiles: this is not my code, and is provided in a single folder. Considering there will likely be a new version, moving the header files and updating all of the dependencies now does not seem like a useful operation. Can you suggest a better way to include these source files?
2. Fixed
3. They are used to generate dome cpp files for compilation. I have moved them to common/VAL...
4. Fixed

[ipa-jsf]

@m312z Thanks for your update. I've accepted your PR. Please update your repository and check the following:

• squirrel_planning_system: Is it necessary to check in the popf binary? If not, please remove it.
• squirrel_planning_system: Could you move the VALFiles to a separate package called val (or similar) e.g. see object_recognition/v4r (which is still not in a final state, but putting external code into a separate package seems to be a good idea). Then you need to add is as a library to use it in other packages.
• squirrel_planning_system: In order to compile, I've added src/VALfiles to your include paths in CMakeLists.txt
• squirrel_planning_system: InVALfiles/ptree.h I had to put a this-> before all insert function calls.
• squirrel_planning_system: In VALfiles/Validator.cpp function Gantt::getSigObjs, the variable i was defined twice. I renamed one of the definitions.
• squirrel_planning_system: Removed run and build dependency on diagnostic_msgs from package.xml
• squirrel_planning_system: Removed dependency on _systemlib from CMakeLists.txt
• squirrel_knowledge_base: Added run and build dependency on rostest to package.xml
• squirrel_knowledge_base: Removed run and build dependency on diagnostic_msgs from package.xml
• squirrel_knowledge_base: Removed dependency on _systemlib from CMakeLists.txt

Please use catkin_lint to check your package before commiting. The build error most likely come from my newer compiler version. I've build it with Ubuntu 14.04 on indigo. Could you update your username or image, please.