search

squirrel-project / squirrel_robotino

This repository holds packages for hardware launch files and configuration, as well as the simulation model for starting up the basic layer for operating Robotino
3 stars 14 forks source link

Arm review #215

Closed ipa-nhg closed 7 years ago

ipa-nhg commented 7 years ago

Thanks @philkark @philkark @lokalmatador @mzillich please review

ghost commented 7 years ago

LGTM though cannot test. But I guess it's fine.

tpatten commented 7 years ago

See comments in https://github.com/squirrel-project/squirrel_common/pull/235

ipa-nhg commented 7 years ago

This PR should be ok, it is updating the mount position of the arms and move the arm by default to the folded position on simulation, after the merge of https://github.com/squirrel-project/squirrel_common/commit/9658e6e75fa022cb248a7cb5af81ff9574efd4d0 should work.