search

squirrellyjs / squirrelly

Semi-embedded JS template engine that supports helpers, filters, partials, and template inheritance. 4KB minzipped, written in TypeScript ⛺
https://squirrelly.js.org
MIT License
634 stars 83 forks source link

Site: Playground page breaks #135

Closed fatganz closed 4 years ago

fatganz commented 4 years ago

Describe the bug When inserting potentially invalid template whole Playground page breaks.

To Reproduce Steps to reproduce the behavior:

  1. Go to the playground page
  2. insert the following snippet {{if(htmlstuff)}}test{{/if}}
  3. whole playground page is broken

Expected behavior The playground page shouldn't break because people are trying to learn new things there. It should be safe for them to insert anything and the page should remain functional so they can identify where the error is in their code and fix it. For the project promotion reasons please make sure playground never breaks :)

nebrelbug commented 4 years ago

@fatganz so sorry - I'll work to fix this issue. In the meantime, you can use: https://raw.githack.com/squirrellyjs/squirrelly/master/demo.html

fatganz commented 4 years ago

Thanks for the quick reply and workaround! Not sure if this is an appropriate place, but thanks for keeping project alive.

nebrelbug commented 4 years ago

I've updated the Playground page, so closing now :smiley: