search

squirrellyjs / squirrelly

Semi-embedded JS template engine that supports helpers, filters, partials, and template inheritance. 4KB minzipped, written in TypeScript ⛺
https://squirrelly.js.org
MIT License
571 stars 81 forks source link

check if the native prototype method exists by evaluating it. #195

Closed vinothbabu closed 4 years ago

vinothbabu commented 4 years ago

The change is for the below error thrown from typescript "This condition will always return true since the function is always defined. Did you mean to call it instead? "

nebrelbug commented 4 years ago

I think now you'll have to ESLint-disable no-extra-boolean-cast, it's something like (on the same line as the condition in the if statement)

if (...) { // eslint-disable-line no-extra-boolean-cast
vinothbabu commented 4 years ago

The build passed, but why is the Codacy not able to pull my request for quality review?

vinothbabu commented 4 years ago

@nebrelbug Do you see any issue with the pull request?

nebrelbug commented 4 years ago

@vinothbabu this looks great to me :tada:! I think I haven't set up Codacy to work correctly with contributor PR's.

I'll merge this today or tomorrow, and leave this open so I remember :)

nebrelbug commented 4 years ago

@vinothbabu so sorry I took so long to merge this! I just released version 8.0.2, which incorporates this PR.

vinothbabu commented 4 years ago

@nebrelbug That's absolutely fine, thanks. I will be happy to help more!