search

squirrellyjs / squirrelly

Semi-embedded JS template engine that supports helpers, filters, partials, and template inheritance. 4KB minzipped, written in TypeScript ⛺
https://squirrelly.js.org
MIT License
571 stars 81 forks source link

Allow any number of arguments that are strings #203

Closed jmclean-cnexus closed 3 years ago

jmclean-cnexus commented 3 years ago

Update Typings for FilterFunction to reflect usage on https://squirrelly.js.org/docs/api/filter-api, allowing multiple input args.

nebrelbug commented 3 years ago

@jmclean-cnexus thanks for the PR!

jmclean-cnexus commented 3 years ago

@nebrelbug anything else i can do to the PR to get it to merge. BTW...thanks for such an awesome module; I think ill be using/recommending it for many of my future solutions.

nebrelbug commented 3 years ago

@jmclean-cnexus this looks great! I'll merge now :tada:.

BTW...thanks for such an awesome module; I think ill be using/recommending it for many of my future solutions.

Thank you! I'm glad you enjoy it!

By the way, is it alright if I add you to the README as a contributor?

jmclean-cnexus commented 3 years ago

I would be proud to be on the readme, and will hopefully provide more quality PRs in the future!

nebrelbug commented 3 years ago

@jmclean-cnexus awesome! I hope you can!

@all-contributors please add @jmclean-cnexus for his coding contributions :tada:

allcontributors[bot] commented 3 years ago

@nebrelbug

I've put up a pull request to add @jmclean-cnexus! :tada:

nebrelbug commented 3 years ago

@jmclean-cnexus just added you :smiley: