Comment about reassigning lastIndex

first-timers[bot] commented 6 years ago

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[x] 🙋 Claim this issue: Comment below.

Once claimed we add you as contributor to this repository.
[x] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue
[ ] 📝 Update the file src/compile.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -83,7 +83,7 @@ function Compile (str) {
         var nativeH = nativeHelpers[parent.name]
         if (nativeH.blocks && nativeH.blocks[m[9]]) {
           funcStr += nativeH.blocks[m[9]](parent.id)
-          lastIndex = regEx.lastIndex
+          lastIndex = regEx.lastIndex // Some native helpers set regEx.lastIndex
         } else {
           console.warn("Native helper '%s' doesn't accept that block.", parent.name)
         }

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can edit files directly in your browser

[ ] 🏁 Done Ask in comments for a review :)

squirrellyjs / squirrelly

Comment about reassigning lastIndex #62

🆕🐥☝ First Timers Only.

🤔 What you will need to know.

📋 Step by Step

🤔❓ Questions