Comment about self-closing helpers

first-timers[bot] commented 5 years ago

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[x] 🙋 Claim this issue: Comment below.

Once claimed we add you as contributor to this repository.
[x] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue
[x] 📝 Update the file src/compile.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -112,7 +112,7 @@ function Compile (str) {
         funcStr += nativeHelpers[m[10]].selfClosing(innerParams)
         lastIndex = regEx.lastIndex // changeTags sets regEx.lastIndex
       } else {
-        funcStr += 'tR+=Sqrl.H.' + m[10] + '(' + innerParams + ');'
+        funcStr += 'tR+=Sqrl.H.' + m[10] + '(' + innerParams + ');' // If it's not native, passing args to a non-native helper
       }
     } else {
       console.error('Err 0')

[x] 💾 Commit your changes
[x] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can edit files directly in your browser

[x] 🏁 Done Ask in comments for a review :)

squirrellyjs / squirrelly

Comment about self-closing helpers #63

🆕🐥☝ First Timers Only.

🤔 What you will need to know.

📋 Step by Step

🤔❓ Questions