Explain why we trim each filter

first-timers[bot] commented 6 years ago

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[x] 🙋 Claim this issue: Comment below.

Once claimed we add you as contributor to this repository.
[x] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue
[ ] 📝 Update the file src/filters.js in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -78,7 +78,7 @@ export function parseFiltered (initialString, filterString) {
   if (filterString && filterString !== '') {
     filtersArray = filterString.split('|')
     for (var i = 0; i < filtersArray.length; i++) {
-      filtersArray[i] = filtersArray[i].trim()
+      filtersArray[i] = filtersArray[i].trim() // Just in case someone put | filter| or | filter | or something similar
       if (filtersArray[i] === '') continue
       if (filtersArray[i] === 'safe') {
         // If 'safe' is one of the filters, set safe to true but don't add Sqrl.F.safe

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can edit files directly in your browser

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

hkulur commented 6 years ago

Hey, First timer here! I want to claim this issue.

kcamozzi commented 6 years ago

I would like to claim this issue.

esslamben commented 6 years ago

Hi, I would like to claim this issue :)

nebrelbug commented 6 years ago

Reserved for @hkulur, since he commented first. @kcamozzi, @iRewiewer, and @Esslamb, hopefully there will be more opportunities for you soon :)

hkulur commented 6 years ago

Thanks @nebrelbug! Have raised a PR #81 for this.

squirrellyjs / squirrelly