Add comment to example Sqrl file

first-timers[bot] commented 5 years ago

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below.

Once claimed we add you as contributor to this repository.
[ ] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue
[ ] 📝 Update the file examples/views/index.sqrl in the squirrelly repository (press the little pen Icon) and edit the line as shown below.

@@ -4,7 +4,8 @@
     <title>{{title}}</title>
   </head>
   <body>
+    {{!--comment--}}
     <p>It works!</p>

   </body>
-</html>
\ No newline at end of file
+</html>

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can edit files directly in your browser

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

dlarner3194 commented 5 years ago

I'll grab this one

nebrelbug commented 5 years ago

@dlarner3194 since you've already contributed, will you work on a different, not 'first-timers-only' issue? Maybe you could work on #65. Thanks for your enthusiasm!

dlarner3194 commented 5 years ago

@nebrelbug looks like that one has already been assigned. Can I get started on it anyways?

nebrelbug commented 5 years ago

@dlarner3194 Yes, a couple of people can be working on that issue. There's no such thing as too many resources for beginners!

jeanha124 commented 5 years ago

can I do this one as well?

nebrelbug commented 5 years ago

@jeanha124 sorry, this one has already been assigned. You could work on one of the other available issues though, or work on #65 (which a couple of people can be working on). Thanks!

nebrelbug commented 5 years ago

Sorry @jeanha124, just realized it hasn't been assigned 😄. You can work on it if you want.

jeanha124 commented 5 years ago

thank you

bourguy commented 5 years ago

Hi @nebrelbug , Can I claim that one? Looks like it is still open. Thanks!

nebrelbug commented 5 years ago

It's assigned to @jeanha124. @jeanha124, if you're not available to work on the project within the next couple of days, could you let @bourguy work on this issue instead? Thanks!

jeanha124 commented 5 years ago

I made a pull request a couple days ago, but didn’t get a response.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Ben Gubler notifications@github.com Sent: Friday, October 12, 2018 15:41 To: nebrelbug/squirrelly Cc: Jean Ha; Mention Subject: Re: [nebrelbug/squirrelly] Add comment to example Sqrl file (#85)

It's assigned to @jeanha124https://github.com/jeanha124. @jeanha124https://github.com/jeanha124, if you're not available to work on the project within the next couple of days, could you let @bourguyhttps://github.com/bourguy work on this issue instead? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/nebrelbug/squirrelly/issues/85#issuecomment-429440432, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGfIkjavrNyISZTH63FrOdFsY-so8yELks5ukPBRgaJpZM4XK5e4.

nebrelbug commented 5 years ago

@jeanha124 I reviewed your pull request, but it must not have sent you a notification :). Just click on the pull request and you should be able to see it. Thanks!

squirrellyjs / squirrelly