squirrellyjs / squirrelly

Semi-embedded JS template engine that supports helpers, filters, partials, and template inheritance. 4KB minzipped, written in TypeScript ⛺
https://squirrelly.js.org
MIT License
599 stars 82 forks source link

Add explanation of funcStr #86

Closed first-timers[bot] closed 5 years ago

first-timers[bot] commented 5 years ago

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

@@ -12,7 +12,7 @@ import P from './partials'

 function Compile (str) {
   var lastIndex = 0
-  var funcStr = ''
+  var funcStr = '' // This will be called with Function() and returned
   var helperArray = [] // A list of all 'outstanding' helpers, or unclosed helpers
   var helperNumber = -1
   var helperAutoId = 0 // Squirrelly automatically generates an ID for helpers that don't have a custom ID
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

JoeCrescoll commented 5 years ago

Hello,

I'd be glad to try to make my first open source contribution with this issue :)

nebrelbug commented 5 years ago

@JoeCrescoll awesome! I'll reserve this issue for you 😃

JoeCrescoll commented 5 years ago

Done :)

Feel free to tell me if i missed or did something wrong.