squirrellyjs / squirrelly

Semi-embedded JS template engine that supports helpers, filters, partials, and template inheritance. 4KB minzipped, written in TypeScript β›Ί
https://squirrelly.js.org
MIT License
599 stars 82 forks source link

Add explanation of why Compile = {} in runtime #87

Closed first-timers[bot] closed 5 years ago

first-timers[bot] commented 5 years ago

πŸ†•β˜ First Timers Only

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ˜ƒ

About First Timers Only.

πŸŽƒπŸ’»πŸ‘• Hacktoberfest: Trick or Treat!

If you haven’t yet, sign up for Hacktoberfest to earn a limited edition T-shirt.

πŸ€” What you will need to know

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

:clipboard: Step by Step

@@ -144,7 +144,7 @@ function Compile (str) {
   return func
 }

-if (RUNTIME) {
+if (RUNTIME) { // Don't include Sqrl.Compile() in the runtime library, to make it more lightweight
   Compile = {} // eslint-disable-line no-func-assign
 }

πŸ€”β“ Questions

Comment and we'll try to help as soon as possible πŸ˜ƒ

chepora commented 5 years ago

Hi! I would like to help with that.

nebrelbug commented 5 years ago

@chepora awesome! I'll reserve it for you.

chepora commented 5 years ago

Thank you! PR: #89