search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
104 stars 63 forks source link

fix(x1_boost): totals are consecutive u16 ints #129

Closed kalosisz closed 9 months ago

kalosisz commented 1 year ago

Total values are two consecutive unsigned 16bit integers for X1 Boost inverter.

kalosisz commented 1 year ago

hey @squishykid, the values for the test case are from our X1 Boost inverter. We have been using the Solax plugin in HomeAssistant, but unfortunatelly, some of the values are wrong.

kalosisz commented 9 months ago

I've added the new text case for the overflown case.

squishykid commented 9 months ago

Do this by adding another ‘ InverterUnderTest’ in fixtures.py, referencing your new test values

kalosisz commented 9 months ago

I should've checked! Fixture added.

squishykid commented 9 months ago

Nice work!

kalosisz commented 9 months ago

Thanks! How do new versions get released? I'd need this fix for updating the deps in here.

dooblem commented 9 months ago

Hello thanks guys. Just tested with the very last git version today.

I don't know if this is the right place to post. My X1 Boost G3 is detected as "X1MiniV34". Is it OK ? When removing X1MiniV34 from discovery.py, still not detected as X1 Boost.

I'm still getting some data though. From first look the data seems OK.

Elliottmonaghan commented 6 months ago

Hello thanks guys. Just tested with the very last git version today.

I don't know if this is the right place to post.

My X1 Boost G3 is detected as "X1MiniV34". Is it OK ?

When removing X1MiniV34 from discovery.py, still not detected as X1 Boost.

I'm still getting some data though. From first look the data seems OK.

This is what I have experienced also. The values mostly line up but the exported power/power now values are not lined up so will not work, also the x1 boost Gen 3 uses a pack_u16 to combine a few values so some of the total values will be off. I have changed this manually on the x1 mini v34 file and got it reporting correct values but haven't delved into it on how to get it to register as an x1 boost on initial discovery.