search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
100 stars 57 forks source link

Optional model parameter #133

Closed rowinho closed 6 months ago

rowinho commented 1 year ago

Adding optional "model" parameter for discovery, in order to allow consumers (e.g. Homeassistant) to specify inverter model for quicker discovery.

This addresses issues where discovery takes long time to complete, sometimes not completing at all.

luismsousa commented 7 months ago

Giving it a bump to check if someone can review and merge.

squishykid commented 7 months ago

Can you please have a look at why the tests aren't running? I would like to run the tests before doing a review

luismsousa commented 7 months ago

Can you please have a look at why the tests aren't running? I would like to run the tests before doing a review

@squishykid I've re-submitted @rowinho 's PR as I couldn't push to his fork. I've opened #140 to force the trigger for the github action. https://github.com/squishykid/solax/actions/runs/7833149301 it's waiting your action for it to start. Cheers 👋

You might need to cancel the github action that's hanging. Alternatively, feel free to make me a contributor/maintainer and I'll help troubleshoot the actions.

squishykid commented 7 months ago

I just modified the settings on solax, so I shouldn't need to approve the github actions as often for new contributors.

Darsstar commented 6 months ago

This PR can probably be closed since #145 has been merged.