search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
100 stars 57 forks source link

X3 Hybrid G4: Attributes added #136

Closed SebStaeubert closed 6 months ago

SebStaeubert commented 10 months ago

Content:

Open:

refs #80

squishykid commented 7 months ago

Can you please pull in master? Then we can run the tests

SebStaeubert commented 7 months ago

Can you please pull in master? Then we can run the tests

I tried to. Is ok now? It is still squishykid:master. I cannot choose any other.

squishykid commented 7 months ago

You have the PR all correct :)

To clarify, I mean that you need to update your branch by 'pulling in' all the changes from upstream's master (squishykid/solax repo [this repo]). These changes include new testing infrastructure.

There's a guide here: https://www.atlassian.com/git/tutorials/git-forks-and-upstreams. You will need to set this repo (squishykid/solax) as the 'upstream'.

squishykid commented 7 months ago

There's also another set of instructions here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line

Under the section "Syncing a fork branch from the command line"

SebStaeubert commented 6 months ago

@squishykid finally, all test are fine. I learned a lot (i have no skills in python...) :-)

squishykid commented 6 months ago

Nice work. Now you can raise a PR against home-assistant to bump the solax package to v3.0.5. Then your changes will be included in the next release!