search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
100 stars 57 forks source link

Make it possible to specify the inverter type when initializing the library, and bypass the discovery process. #138

Closed brew-your-own closed 6 months ago

brew-your-own commented 8 months ago

in the case where the Inverter type is already known.

Some inverters at the end of the REGISTRY (e.g. X1HybridGen4) randomly crash because the discovery code issues too many incorrect requests before sending the correct one. This patch adds a variant of the entry point in which one can specify the name of the inverter type.

This addresses https://github.com/home-assistant/core/issues/66617 and https://github.com/home-assistant/core/issues/99421

brew-your-own commented 8 months ago

This is similar to https://github.com/squishykid/solax/pull/133 I have not tried PR 133, if it solves the same problem then it is a simpler solution.

brew-your-own commented 6 months ago

ok so we now have working solutions to bypass the discovery code: one in this PR, and another in https://github.com/squishykid/solax/pull/144

Which do you prefer?

I have a prototype solution to the downstream homeassistant problem that I would like to finish up and push.

brew-your-own commented 6 months ago

I have tested https://github.com/squishykid/solax/pull/133 and I think it is a better solution: simpler / smaller. It works quite well in HA. Closing this PR.