search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
100 stars 57 forks source link

Optional model parameter to bypass discovery #144

Closed brew-your-own closed 6 months ago

brew-your-own commented 6 months ago

This is another solution to the problem described here: https://github.com/home-assistant/core/issues/66617

The other solution is in https://github.com/squishykid/solax/pull/138 and is slightly more complicated because it introduces a new entrypoint to the library.

The solution here was originally implemented in https://github.com/squishykid/solax/pull/133 by @rowinho then modified to pass tests by @luismsousa My modification is in the test suite to make sure coverage is 100%.

I could not modify directly one of the previous PRs, so this is yet another PR. This one passes all tests on python 3.8/3.9/3.10 on my mac.

brew-your-own commented 6 months ago

Any update on this PR? This works quite well, I have tested this version in HA and have some improvements to the component ready to go. We just need to release this change.

brew-your-own commented 6 months ago

hello @squishykid , is there anything else you need to review and merge this in? this patch is needed to fix downstream issues in Home Assistant

Darsstar commented 6 months ago

This PR can probably be closed since #145 has been merged.

brew-your-own commented 6 months ago

closing because a better fix was merged in.