search

squishykid / solax

🌞 Solax Inverter API Wrapper
MIT License
104 stars 63 forks source link

raise validation error for all zero response data #148

Closed Darsstar closed 5 months ago

Darsstar commented 7 months ago

Succeeds #142, thanks @VadimKraus.

VadimKraus commented 7 months ago

how about we just reopen #142 :D

Darsstar commented 7 months ago

how about we just reopen #142 :D

I can't. Feel free to rebase your branch on master yourself.

VadimKraus commented 7 months ago

Ah sorry, there were conflicts again? nvm then :P

joseal commented 6 months ago

@Darsstar, could you please confirm if this change was already merged/deployed? sorry, because I'm already a bit confused...

Darsstar commented 6 months ago

For all intents and purposes: no, it has not.

squishykid commented 5 months ago

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

Darsstar commented 5 months ago

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

I went ahead and created https://github.com/home-assistant/core/pull/118888